Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starter showcase - detail page wireframes #6709

Closed
6 tasks done
shannonbux opened this issue Jul 24, 2018 · 10 comments
Closed
6 tasks done

Starter showcase - detail page wireframes #6709

shannonbux opened this issue Jul 24, 2018 · 10 comments
Assignees

Comments

@shannonbux
Copy link
Contributor

shannonbux commented Jul 24, 2018

Sub-tasks:

startershowcasedetail

@shannonbux shannonbux changed the title Starter showcase detail page should match look and feel of wireframe [Project] detail page should match look and feel of wireframe - starter showcase Jul 24, 2018
@shannonbux shannonbux changed the title [Project] detail page should match look and feel of wireframe - starter showcase [Project] detail page should match wireframes - starter showcase Jul 26, 2018
@shannonbux shannonbux assigned swyxio and unassigned fk Jul 26, 2018
@swyxio
Copy link
Contributor

swyxio commented Jul 26, 2018

fwiw i would not recommend pulling in the README as there are no limitations on how they are formatted and its really hard to make that look presentable. for example what if the readme includes a screenshot of the demo? then our page has two screenshots

@swyxio
Copy link
Contributor

swyxio commented Jul 26, 2018

fixing

waiting for more input

feedback

drop shadow around screenshot to match site showcase detail page #6766

there is no drop shadow in the direct page view (example); it only shows up in the modal view. last i recall we decided against having the modal view for the starter showcase.

@shannonbux
Copy link
Contributor Author

Ok instead of the READme we'll just have a field that can be filled out in the .yml file.

@fk can you answer the question above about the modal views:

it only shows up in the modal view. last i recall we decided against having the modal view for the starter showcase.

@swyxio
Copy link
Contributor

swyxio commented Jul 27, 2018

re: yml vs readme

yea so fwiw i'm working with markdown instead of yml files for this exact purpose. when they submit they can choose to fill out the body of the markdown with whatever they want and we can choose to display it in future. its an intentional point of departure from the site showcase because i believe this is better long term. i struggle with it because of this difference but kyle knows i'm doing this and has never told me otherwise so i stuck with what i had for now (since i already did all the manual data entry).

@shannonbux
Copy link
Contributor Author

shannonbux commented Jul 27, 2018 via email

@fk
Copy link
Contributor

fk commented Jul 31, 2018

@sw-yx

drop shadow around screenshot to match site showcase detail page #6766

there is no drop shadow in the direct page view (example); it only shows up in the modal view. last i recall we decided against having the modal view for the starter showcase.

There is a subtle box-shadow for the screenshot in the permalink/direct page view: https://next.gatsbyjs.org/showcase/reactjs.org/. It's there to separate screenshots that contain a lot of white from the white page background.

@swyxio
Copy link
Contributor

swyxio commented Aug 1, 2018

ok. i'm happy to push the last mile on this if you are willing to work with me on it, but im not sure what to do about it now that it has been moved to backlog.

@shannonbux shannonbux assigned amberleyromo and unassigned swyxio Aug 24, 2018
@shannonbux shannonbux changed the title [Project] detail page should match wireframes - starter showcase Starter showcase - detail page wireframes Aug 29, 2018
@shannonbux shannonbux assigned fk and unassigned amberleyromo Aug 29, 2018
@shannonbux
Copy link
Contributor Author

Hi @fk! Could you just add any new mockups or notes on what you're planning to do here? Thanks!

@amberleyromo
Copy link
Contributor

@shannonbux --

@fk dropped mockup details over on this issue: #6710 (comment)

Not sure if you want to consolidate issues here, perhaps

@shannonbux
Copy link
Contributor Author

Closing in favor of #6710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants