-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starter showcase - detail page wireframes #6709
Comments
fwiw i would not recommend pulling in the README as there are no limitations on how they are formatted and its really hard to make that look presentable. for example what if the readme includes a screenshot of the demo? then our page has two screenshots |
fixing
waiting for more input
feedback
there is no drop shadow in the direct page view (example); it only shows up in the modal view. last i recall we decided against having the modal view for the starter showcase. |
Ok instead of the READme we'll just have a field that can be filled out in the .yml file. @fk can you answer the question above about the modal views:
|
re: yml vs readme yea so fwiw i'm working with markdown instead of yml files for this exact purpose. when they submit they can choose to fill out the body of the markdown with whatever they want and we can choose to display it in future. its an intentional point of departure from the site showcase because i believe this is better long term. i struggle with it because of this difference but kyle knows i'm doing this and has never told me otherwise so i stuck with what i had for now (since i already did all the manual data entry). |
oh ok! I'll make sure the instructions make this clear :)
…On Fri, Jul 27, 2018 at 3:07 PM, shawn wang ***@***.***> wrote:
re: yml vs readme
yea so fwiw i'm working with markdown instead of yml files for this exact
purpose
<https://github.com/sw-yx/gatsby/tree/starterShowcase2/www/src/data/StarterShowcase/startersData>.
when they submit they can choose to fill out the body of the markdown with
whatever they want and we can choose to display it in future. its an
intentional point of departure from the site showcase because i believe
this is better long term. i struggle with it because of this difference but
kyle knows i'm doing this and has never told me otherwise so i stuck with
what i had for now (since i already did all the manual data entry).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6709 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae9o2vPcQx9np0mbHdj6ItTBRQzua567ks5uK4D5gaJpZM4Vd77q>
.
|
There is a subtle |
ok. i'm happy to push the last mile on this if you are willing to work with me on it, but im not sure what to do about it now that it has been moved to backlog. |
Hi @fk! Could you just add any new mockups or notes on what you're planning to do here? Thanks! |
@shannonbux -- @fk dropped mockup details over on this issue: #6710 (comment) Not sure if you want to consolidate issues here, perhaps |
Closing in favor of #6710 |
Sub-tasks:
The text was updated successfully, but these errors were encountered: