Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www/showcase] Revisit detail page header layout #6098

Closed
deadcoder0904 opened this issue Jun 22, 2018 · 9 comments
Closed

[www/showcase] Revisit detail page header layout #6098

deadcoder0904 opened this issue Jun 22, 2018 · 9 comments
Assignees
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@deadcoder0904
Copy link
Contributor

deadcoder0904 commented Jun 22, 2018

Visit https://next.gatsbyjs.org/showcase/cardiogr-am/ & see the buttons "Visit Site" & "Share" buttons are overlapping on the site screenshot & it looks like the image is cut in or page didn't load properly. Place it somewhere nice :)

Its happening for many sites. Its overlapping Navbar Text on many sites.

@pieh
Copy link
Contributor

pieh commented Jun 22, 2018

/cc @kkemple @fk

@pieh pieh added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jun 22, 2018
@swyxio
Copy link
Contributor

swyxio commented Jun 24, 2018

as-designed, really

@deadcoder0904
Copy link
Contributor Author

Yep that's why I said place it somewhere nice really 😂

@fk
Copy link
Contributor

fk commented Jun 25, 2018

Agreed. I'll give placing the "Visit Site" button next to the URL below the site title and moving the "Share" buttons into the header a go over the next days.

@fk
Copy link
Contributor

fk commented Jun 26, 2018

Here's a very quick shot at alternative "Visit Site" and "Share" button positions for Desktop:

image

Alternatively we maybe could just move the two buttons to the lower right corner of the image—that'd mean only slight adjustments for Desktop vs Mobile.

That said, I think we should keep the current button positions on Mobile; I might be too precautious, but I'd rather not deal with the implications (e.g. a very long URL) of placing the buttons next (or below) text here:

image

@deadcoder0904
Copy link
Contributor Author

@fk looks nice

@fk fk changed the title Do not overlap Visit Site & Share button on Websites of Showcase Page [www/showcase] Do not overlap Visit Site & Share button on Websites of Showcase Page Jul 24, 2018
@fk fk changed the title [www/showcase] Do not overlap Visit Site & Share button on Websites of Showcase Page [www/showcase] Do not display "Visit Site" & "Share" buttons above site screenshot on detail pages/revisit detail page header layout Jul 25, 2018
@fk fk changed the title [www/showcase] Do not display "Visit Site" & "Share" buttons above site screenshot on detail pages/revisit detail page header layout [www/showcase] Revisit detail page header layout Jul 31, 2018
@fk
Copy link
Contributor

fk commented Jul 31, 2018

Posted a first stab at trying to consolidate header designs of site and starter showcase in #6710 (comment)

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Dec 16, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 16, 2018

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

@fk
Copy link
Contributor

fk commented Dec 17, 2018

Hey gatsbot, this actually has been fixed. 🎉
Thanks for reminding me! 🙏

@fk fk closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

No branches or pull requests

4 participants