-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-emotion): update plugin for emotion v10 #10226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, we're likely going to be adding a babel preset for automatically adding the jsx pragma (emotion-js/emotion#1049)
The peerDep handles it right? Requiring v10 of packages as peerDependencies should cover our bases there. |
Cool with me if peerDep bumps are good enough, just wasn't sure since bumping this plugin version by a minor or patch would convey non-breaking changes but an emotion v9 consumer's build will explode because the plugin now imports from |
Oh yeah. This would be a major version bump for this plugin! Misunderstood you there. |
Cool. I bumped it to |
@wKovacs64 I'm so sorry, that's my fault on that one! If you could, could you revert that commit, e.g. git revert f05f5a2 and then push that up to this branch. We actually use Before we merge, we'll want to edit the description with something like
so that we can get that info in the changelog. |
This reverts commit f05f5a2.
@DSchau Sure, no problem. Will that handle bumping the |
It will! |
Word. |
I assume whoever merges do that, but let me know if you need me to do something else in that regard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
@wKovacs64 I'll take a look at this today and get it merged in. Thanks to both you and @mitchellhamilton! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge. Thanks again!
|
😅 |
Doesn't look like lerna updated the example, I'll send another PR for that. |
@wKovacs64 ah, yep 😢 Good catch on the missed breaking change. My fault! |
…10226) # 🎉 Emotion v10 is here! 🎉 - [X] Update dependencies - [X] Update critical style handling - [X] Add Babel config for `jsx` pragma - [X] Update plugin install instructions - [X] Update Gatsby tutorial (part 4) - [X] Update the "using emotion" example
🎉 Emotion v10 is here! 🎉
jsx
pragma