Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): don't crash if cpu-core-count is not available #12332

Merged
merged 2 commits into from Mar 5, 2019
Merged

fix(*): don't crash if cpu-core-count is not available #12332

merged 2 commits into from Mar 5, 2019

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 5, 2019

fixes #12307

DSchau
DSchau reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just make this a little helper since we're basically copy/pasting here?

Didn't realize it was separate plugins 🤦‍♂️ Looks good!

@DSchau DSchau changed the title fix: don't crash if cpu-core-count is not available fix(*): don't crash if cpu-core-count is not available Mar 5, 2019
@DSchau
Copy link
Contributor

DSchau commented Mar 5, 2019

@pieh for the lint failure, see #12334

@pieh
Copy link
Contributor Author

pieh commented Mar 5, 2019

@pieh for the lint failure, see #12334

Nice, merged that one and updated this branch so it can be nice and green ;)

DSchau
DSchau approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DSchau
Copy link
Contributor

DSchau commented Mar 5, 2019

Wish there was a conventional changelog message for multiple, e.g.

fix(gatsby-plugin-sharp, gatsby-plugin-manifest): fix some issue

@DSchau DSchau merged commit 412217d into gatsbyjs:master Mar 5, 2019
@pieh pieh deleted the cpu-count-fallback branch March 5, 2019 21:31
@DSchau
Copy link
Contributor

DSchau commented Mar 5, 2019

Successfully published:

  • gatsby-plugin-manifest@2.0.22
  • gatsby-plugin-sharp@2.0.25

@pieh pieh mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-sharp 2.0.24 requires gatsby@2.1.20 but specifies peer dependency of gatsby@^2.0.0
3 participants
@pieh @DSchau @KyleAMathews