Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-core-utils): add url resolve #15510

Merged
merged 5 commits into from
Jul 12, 2019
Merged

feat(gatsby-core-utils): add url resolve #15510

merged 5 commits into from
Jul 12, 2019

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jul 8, 2019

Description

2 things happen here:

  1. I renamed the gatsby-utils folder to match the gatsby-core-utils package name
  2. added urlResolve util as joinPath is used to store windows path as a string and not to join paths with '/'.

The reason for not using path.posix.join is that it doesn't covert \ into /

Related Issues

#15370

@wardpeet wardpeet requested a review from a team as a code owner July 8, 2019 09:10
@wardpeet wardpeet mentioned this pull request Jul 8, 2019
Merged
@wardpeet wardpeet requested a review from a team as a code owner July 12, 2019 13:28
sidharthachatterjee
sidharthachatterjee previously approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 12, 2019
@sidharthachatterjee
Copy link
Contributor

@wardpeet Linting issue

[gatsby-core-utils] repository and/or homepage field in package.json are out of date.Run "yarn run check-repo-fields -- --fix" to update.

sidharthachatterjee
sidharthachatterjee approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gatsbybot gatsbybot merged commit 1dbe332 into gatsbyjs:master Jul 12, 2019
@wardpeet wardpeet deleted the feat/url-resolve branch July 12, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wardpeet @sidharthachatterjee @gatsbybot