Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump terser-webpack-plugin to v.1.4.2 #20014

Merged

Conversation

alexandre-lelain
Copy link
Contributor

Description

A security breach was found in serialize-javascript (versions < 2.1.1) which is one of the dependencies of gatsby's terser-webpack-plugin dependency.

This PR bumps the version of terser-webpack-plugin to 2.2.2 to fix the security breach. See https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md.

You can find the security alert here: GHSA-h9rv-jmmf-4pgx.

Even if the version update was a major one, the build seems to be passing.

@alexandre-lelain alexandre-lelain requested a review from a team as a code owner December 9, 2019 15:09
@pieh
Copy link
Contributor

pieh commented Dec 9, 2019

Even if the version update was a major one, the build seems to be passing.

Switching from 1.X to 2.x might need more changes - given this list of breaking changes (not sure, just testing if build doesn't crash doesn't seem like enough of research):

https://github.com/webpack-contrib/terser-webpack-plugin/releases/tag/v2.0.0

There is release for 1.X line as well that fixes same thing: https://github.com/webpack-contrib/terser-webpack-plugin/releases/tag/v1.4.2

@alexandre-lelain
Copy link
Contributor Author

You're totally right, we better use this one instead. 👍 The 1.4.2 doesn't seem to appear in their changelog so I may have missed it. I will make a change to use this version instead.

Thanks!

@alexandre-lelain alexandre-lelain changed the title build(deps): bump terser-webpack-plugin to v.2.2.2 for security fix build(deps): bump terser-webpack-plugin to v.1.4.2 for security fix Dec 9, 2019
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pieh pieh changed the title build(deps): bump terser-webpack-plugin to v.1.4.2 for security fix chore(deps): bump terser-webpack-plugin to v.1.4.2 Dec 9, 2019
@pieh pieh merged commit 9227977 into gatsbyjs:master Dec 9, 2019
@gatsbot
Copy link

gatsbot bot commented Dec 9, 2019

Holy buckets, @alexandre-lelain — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants