Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with gatsby-plugin-mdx not picking up gatsbyRemarkPlugins #24194

Merged

Conversation

danedavid
Copy link
Contributor

Fixes #21866.

Description

gatsby-plugin-mdx was not picking up (some?) plugins that were given in gatsbyRemarkPlugins. This adds the logic to do so in mdx-loader used by webpack.

Related Issues

#21866

@danedavid danedavid requested a review from a team as a code owner May 18, 2020 18:22
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 18, 2020
@laurieontech laurieontech added topic: MDX and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 18, 2020
@danedavid
Copy link
Contributor Author

For anyone reviewing, the code is the same as found at https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-mdx/gatsby/source-nodes.js#L94
Maybe we can refactor it out as a common function or module. I first needed to know if this is a good fix 😄

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Was able to verify this fixes the issue.

@laurieontech laurieontech merged commit 431c9bb into gatsbyjs:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-remark-katex] Doesn’t work with gatsby-plugin-mdx
3 participants