Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up How Queries Work #24256

Merged
merged 8 commits into from
Oct 26, 2020
Merged

Clean up How Queries Work #24256

merged 8 commits into from
Oct 26, 2020

Conversation

sidharthachatterjee
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee commented May 20, 2020 •
edited
Loading

Adds mention of the useStaticQuery hook, removes direct references to code, adds mention of query validation.

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner May 20, 2020 10:08
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 20, 2020
@sidharthachatterjee sidharthachatterjee added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: needs core review Currently awaiting review from Core team member status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 20, 2020
@AishaBlake AishaBlake removed the status: needs docs review Pull request related to documentation waiting for review label May 21, 2020
AishaBlake
AishaBlake suggested changes May 22, 2020
View reviewed changes
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick typo fix. I think Michał's point is worth considering. Otherwise, this change LTGM!

docs/docs/query-behind-the-scenes.md Outdated Show resolved Hide resolved
marcysutton
marcysutton suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a nice improvement! Thanks for the PR.

docs/docs/query-behind-the-scenes.md Outdated Show resolved Hide resolved
docs/docs/query-behind-the-scenes.md Outdated Show resolved Hide resolved
meganesu and others added 3 commits October 23, 2020 10:58
@meganesu
Update docs/docs/query-behind-the-scenes.md
ac72090 
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@meganesu
Update docs/docs/query-behind-the-scenes.md
5970bae 
Co-authored-by: Aisha Blake <aisha.g.blake@gmail.com>
@meganesu
Update docs/docs/query-behind-the-scenes.md
eccbf70 
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
meganesu
meganesu previously approved these changes Oct 23, 2020
View reviewed changes
@meganesu meganesu added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 23, 2020
@meganesu meganesu merged commit ed31b35 into master Oct 26, 2020
@meganesu meganesu deleted the docs/query-behind-the-scenes branch October 26, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh left review comments

@AishaBlake AishaBlake AishaBlake requested changes

@marcysutton marcysutton marcysutton requested changes

@meganesu meganesu meganesu approved these changes

Assignees

@pieh pieh

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: needs core review Currently awaiting review from Core team member type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sidharthachatterjee @pieh @marcysutton @meganesu @AishaBlake