-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added encoding arg to "loadNodeContent" method #26174
feat: Added encoding arg to "loadNodeContent" method #26174
Conversation
Find another thing that's Node.js doesn't support Converted PR to draft to think deeper |
Added |
This adds 2nd param (encoding), but it isn't actually used anywhere? Now it's up to transformers to make use of it? Do you use custom transformer in the usecase you shared in #26173 where you would make use of it? |
Hey, |
@pieh Sorry for lack of activity here for last year)) |
Hey! Thanks so much for opening this pull request! Sadly this PR got stale and didn't have any activity for some time. We're trying to do better with PR reviews! To get a better overview of all actionable PRs we're going through all open PRs and triage them. Since we won't be able to do everything and adding new features always means added maintenance burden, we have to be more picky about what's beneficial for the average user and the project itself longterm. Having said all this, we dropped the ball on this PR and we're sorry about not responding to it earlier. As said above, we want to do better in the future but here we should have communicated earlier what will happen with the PR. Unfortunately we won't merge this PR at the moment because there doesn't seem to be a need for it (since no one else requested it). If you still think that this should be added, please open a feature request in our discussions. Thanks! We absolutely want to have you as a contributor and are sorry for any inconveniences we caused with replying too late to this PR. Thanks for submitting to Gatsby! 💜 |
Description
Added second argument to set custom encoding in
loadNodeContent
method.Documentation
https://www.gatsbyjs.org/docs/node-api-helpers/#loadNodeContent
In PR added more details to documentation.
Related Issues
#26173