Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): lazy bundle page components in dev server #27884

Merged
merged 36 commits into from
Nov 17, 2020
Merged

feat(gatsby): lazy bundle page components in dev server #27884

merged 36 commits into from
Nov 17, 2020

Commits on Nov 6, 2020

  1. feat(gatsby): lazy compile page components in dev server 

    This means we only compile the core runtime code initially — page components are only compiled when the user visits the page.
    @KyleAMathews
    KyleAMathews committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b78ee23 View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @KyleAMathews
    KyleAMathews committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    636afaf View commit details
    Browse the repository at this point in the history

  3. Cleanup logs

    @KyleAMathews
    KyleAMathews committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b46f680 View commit details
    Browse the repository at this point in the history

  4. cleanups

    @KyleAMathews
    KyleAMathews committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    a47442e View commit details
    Browse the repository at this point in the history

  5. fix tests

    @KyleAMathews
    KyleAMathews committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    a378040 View commit details
    Browse the repository at this point in the history

  6. Don't bother with navigating — if webpack doesn't update — the user p… 

    …robably has errors in their code or something bigger is wrong so let them just refresh, etc.
    @KyleAMathews
    KyleAMathews committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    a268a4d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. Update packages/gatsby/src/bootstrap/requires-writer.ts 

    Co-authored-by: Ward Peeters <ward@coding-tech.com>
    @KyleAMathews @wardpeet
    KyleAMathews and wardpeet authored Nov 9, 2020
    Configuration menu
    Copy the full SHA
    4d07210 View commit details
    Browse the repository at this point in the history

  2. Update packages/gatsby/cache-dir/dev-loader.js 

    Co-authored-by: Ward Peeters <ward@coding-tech.com>
    @KyleAMathews @wardpeet
    KyleAMathews and wardpeet authored Nov 9, 2020
    Configuration menu
    Copy the full SHA
    59a0385 View commit details
    Browse the repository at this point in the history

  3. Fix lint error

    @KyleAMathews
    KyleAMathews committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    1cef9c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Wait until we know staticQueryHashes are written to page-data.json files 

    We only discover static queries for pages after the component is compiled.

Which means when we lazily add page components, we initially don't know
what static queries should be loaded. To track this, we mark page-data.json
files as not bundled & only after the staticQueryHashes is written do we
accept the page as loaded.
    @KyleAMathews
    KyleAMathews committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    56d5288 View commit details
    Browse the repository at this point in the history

  2. Disable check in production

    @KyleAMathews
    KyleAMathews committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    29db87e View commit details
    Browse the repository at this point in the history

  3. Only trigger compilation/page writing once

    @KyleAMathews
    KyleAMathews committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    afc77cc View commit details
    Browse the repository at this point in the history

  4. Also pull xhr loaded static queries for <StaticQuery>

    @KyleAMathews
    KyleAMathews committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    237d715 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into devjs-lazy

    @KyleAMathews
    KyleAMathews authored Nov 10, 2020
    Configuration menu
    Copy the full SHA
    d23f5fb View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. instance isn't defined in builds apparently

    @KyleAMathews
    KyleAMathews committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    f87a58c View commit details
    Browse the repository at this point in the history

  2. Work around webpack hot reloading bug

    @KyleAMathews
    KyleAMathews committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    208cedf View commit details
    Browse the repository at this point in the history

  3. For static queries, data pushed from websocket is the most fresh

    @KyleAMathews
    KyleAMathews committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    94aa19f View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Centralize logic and prevent it from repeatedly hitting the backend

    @KyleAMathews
    KyleAMathews committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    902cf62 View commit details
    Browse the repository at this point in the history

  2. fix ordering of merge

    @KyleAMathews
    KyleAMathews committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    4bca292 View commit details
    Browse the repository at this point in the history

  3. Comment and add timeout to ensure page-data writes happen after the w… 

    …ebpack compilation
    @KyleAMathews
    KyleAMathews committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    36738e3 View commit details
    Browse the repository at this point in the history

  4. Only add notInDevBundle during development

    @KyleAMathews
    KyleAMathews committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    84fb3b0 View commit details
    Browse the repository at this point in the history

  5. Add back mistakenly removed code

    @KyleAMathews
    KyleAMathews committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    2cf3a66 View commit details
    Browse the repository at this point in the history

  6. Didn't need this

    @KyleAMathews
    KyleAMathews committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    c202cdf View commit details
    Browse the repository at this point in the history

  7. Implement @pieh's idea for telling runtime that dev bundle is loaded

    @KyleAMathews
    KyleAMathews committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    6f55655 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Fix tests

    @KyleAMathews
    KyleAMathews committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    eb88597 View commit details
    Browse the repository at this point in the history

  2. Remove logs

    @KyleAMathews
    KyleAMathews committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    68236bf View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Merge branch 'master' into devjs-lazy

    @KyleAMathews
    KyleAMathews authored Nov 16, 2020
    Configuration menu
    Copy the full SHA
    acfbe67 View commit details
    Browse the repository at this point in the history

  2. Put changes behind GATSBY_EXPERIMENT_LAZY_DEVJS flag

    @KyleAMathews
    KyleAMathews committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    a5fcd13 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Add temporary fork of development-runtime tests for lazy devjs PR

    @KyleAMathews
    KyleAMathews committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    53051e9 View commit details
    Browse the repository at this point in the history

  2. Remove duplicated tests w/ cleaner method @pieh suggested

    @KyleAMathews
    KyleAMathews committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    d140a1b View commit details
    Browse the repository at this point in the history

  3. Address @pieh feedback

    @KyleAMathews
    KyleAMathews committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    68efb11 View commit details
    Browse the repository at this point in the history

  4. Update packages/gatsby/src/utils/start-server.ts 

    Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
    @KyleAMathews @pieh
    KyleAMathews and pieh authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    433918f View commit details
    Browse the repository at this point in the history

  5. Remove global middleware

    @KyleAMathews
    KyleAMathews committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    fbd17a9 View commit details
    Browse the repository at this point in the history

  6. This isn't true

    @KyleAMathews
    KyleAMathews committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    3113e12 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into devjs-lazy

    @KyleAMathews
    KyleAMathews authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    78c0382 View commit details
    Browse the repository at this point in the history

  8. fix lint

    @KyleAMathews
    KyleAMathews committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    34151f9 View commit details
    Browse the repository at this point in the history