Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-gatsby): Try adding sitehash to success event #28136

Merged
merged 1 commit into from
Nov 17, 2020
Merged

feat(create-gatsby): Try adding sitehash to success event #28136

merged 1 commit into from
Nov 17, 2020

Conversation

jamo
Copy link
Contributor

@jamo jamo commented Nov 17, 2020

No description provided.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 17, 2020
mfrachet
mfrachet approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@mfrachet mfrachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ascorbic ascorbic changed the title Try adding sitehash to success event feat(create-gatsby): Try adding sitehash to success event Nov 17, 2020
ascorbic
ascorbic suggested changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test locally before merging please

@jamo jamo added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 17, 2020
@jamo jamo merged commit 6858f22 into master Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the sitehash branch November 17, 2020 19:14
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 18, 2020
@kaocher82 kaocher82 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Jul 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic requested changes

@mfrachet mfrachet mfrachet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamo @ascorbic @mfrachet @LekoArts