Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-filesystem): fix race condition when using publicURL field #28176

Merged
merged 1 commit into from
Nov 20, 2020
Merged

fix(gatsby-source-filesystem): fix race condition when using publicURL field #28176

merged 1 commit into from
Nov 20, 2020

Conversation

styxlab
Copy link
Contributor

@styxlab styxlab commented Nov 19, 2020

Description

Fixes the race condition as discussed in #27984. @pieh: Please review.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 19, 2020
@styxlab
Copy link
Contributor Author

styxlab commented Nov 19, 2020

Let me know how I can fix the ci/circleci: integration_tests_gatsby_cli test.

@pieh
Copy link
Contributor

pieh commented Nov 19, 2020 •
edited
Loading

Let me know how I can fix the ci/circleci: integration_tests_gatsby_cli test.

Ah sorry about this - please don't worry about this - this been flaky test that we didn't yet found a way to fix ( it's very likely unrelated to your changes). I will restart that test (potentially multiple times :S)

@pieh pieh self-assigned this Nov 19, 2020
@pieh pieh added topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 19, 2020
@pieh pieh changed the title fixes /gatsbyjs/gatsby/issues/27984 fix(gatsby-source-filesystem): fix race condition when using publicURL field Nov 20, 2020
pieh
pieh approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pieh pieh merged commit 1abf65c into gatsbyjs:master Nov 20, 2020
@vladar vladar mentioned this pull request Nov 20, 2020
Merged
vladar pushed a commit that referenced this pull request Nov 20, 2020
@styxlab @vladar
fix(gatsby-source-filesystem): fix race condition when using `publicU…
e5d06fb 
…RL` field (#28176)

Co-authored-by: cws <cws@home.fritz.box>
(cherry picked from commit 1abf65c)
vladar added a commit that referenced this pull request Nov 23, 2020
@vladar @styxlab
fix(gatsby-source-filesystem): fix race condition when using `publicU…
e2d1171 
…RL` field (#28176) (#28209)

Co-authored-by: cws <cws@home.fritz.box>
(cherry picked from commit 1abf65c)

Co-authored-by: Joost Jansky <styxlab@users.noreply.github.com>
@vladar
Copy link
Contributor

vladar commented Nov 23, 2020

Published in gatsby-source-filesystem@2.6.1

@notjosh notjosh mentioned this pull request Dec 13, 2020
Closed
This was referenced Mar 15, 2021
Open
Open
Open
Open
Merged
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
@styxlab
fix(gatsby-source-filesystem): fix race condition when using `publicU…
16ee55a 
…RL` field (gatsbyjs#28176)

Co-authored-by: cws <cws@home.fritz.box>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

Labels
topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@styxlab @pieh @vladar