Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-source-shopify): add default sales channel when using shopify app integration #32010

Merged
merged 2 commits into from
Jun 21, 2021
Merged

feat(gatsby-source-shopify): add default sales channel when using shopify app integration #32010

merged 2 commits into from
Jun 21, 2021

Conversation

DanielSLew
Copy link
Contributor

Description

When using the new Shopify Public App Integration, we set the env var GATSBY_SHOPIFY_SALES_CHANNEL on Gatsby Cloud. The plugin will use this value unless the user has already set a salesChannel in their pluginOptions.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 21, 2021
@DanielSLew DanielSLew changed the title add default sales channel when using shopify app integration feat(gatsby-source-shopify): add default sales channel when using shopify app integration Jun 21, 2021
@DanielSLew DanielSLew added the topic: source-shopify Related to the gatsby-source-shopify plugin label Jun 21, 2021
smthomas
smthomas previously approved these changes Jun 21, 2021
View reviewed changes
@DanielSLew DanielSLew merged commit 95280a3 into master Jun 21, 2021
@DanielSLew DanielSLew deleted the add-default-sales-channel-when-using-shopify-app-integration branch June 21, 2021 20:59
@gatsbybot gatsbybot mentioned this pull request Jun 22, 2021
Merged
vladar pushed a commit that referenced this pull request Jun 22, 2021
@DanielSLew @vladar
feat(gatsby-source-shopify): add default sales channel when using sho…
5f3449b 
…pify app integration (#32010)

* add default sales channel when using shopify app integration

* set default salesChannel during schema initialization

(cherry picked from commit 95280a3)
vladar pushed a commit that referenced this pull request Jun 22, 2021
@DanielSLew
feat(gatsby-source-shopify): add default sales channel when using sho…
cb914ae 
…pify app integration (#32010) (#32030)

* add default sales channel when using shopify app integration

* set default salesChannel during schema initialization

(cherry picked from commit 95280a3)

Co-authored-by: Daniel Lew <51924260+DanielSLew@users.noreply.github.com>
This was referenced Jun 23, 2021
Open
Open
Open
Open
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 28, 2021
This was referenced Jan 18, 2022
Open
Open
@0xSebin 0xSebin mentioned this pull request Jun 22, 2022
Open
@monizb monizb mentioned this pull request Oct 27, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Oct 27, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Oct 27, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Dec 14, 2023
Open
@monizb monizb mentioned this pull request Dec 14, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Dec 14, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 14, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 15, 2023
Open
@wizbit wizbit mentioned this pull request Dec 15, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 15, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 15, 2023
Open
@wizbit wizbit mentioned this pull request Dec 15, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 15, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 15, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 15, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 15, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 5, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 5, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 5, 2024
Open
@monizb monizb mentioned this pull request Jan 5, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 5, 2024
Open
@wizbit wizbit mentioned this pull request Jan 5, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
This was referenced Jan 6, 2024
Open
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@monizb monizb mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 6, 2024
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sslotsky sslotsky sslotsky approved these changes

@smthomas smthomas smthomas left review comments

Assignees
No one assigned
Labels
topic: source-shopify Related to the gatsby-source-shopify plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielSLew @sslotsky @smthomas @LekoArts