fix(contentful): createUrl now enforces https protocol #33236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
axe312ger
added
topic: source-contentful
wardpeet
added
the
bot: merge on green
wardpeet
previously approved these changes
Sep 20, 2021
wardpeet
force-pushed
the
fix/contentful-enforce-https-for-images
branch
from
cd7c5a9
to
b150309
Compare
wardpeet
force-pushed
the
fix/contentful-enforce-https-for-images
branch
from
b150309
to
9f173c9
Compare
5 tasks
vladar
pushed a commit
that referenced
this pull request
Oct 5, 2021
Co-authored-by: Ward Peeters <ward@coding-tech.com> (cherry picked from commit e166cfc)
wardpeet
added a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we always have a https variant of an image available in Contentful, we can safely enforce https for all images.
based on @wardpeet's suggestion @ #30391 (comment)
(This will remove noise in the #30391 PR)