-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-drupal): port hot-fixes for Drupal/Gatsby customer to package #33419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough context on drupal plugin but from my shallow review, this looks good 👍
@vladar, I noticed that you merged this PR with 2 checks failing. I'm trying to be of help and this seemed like a first flag along the way. :) Cc: @raresportan |
@cassilup Yeah, sadly,
Lines 334 to 375 in 22805bd
yarn build )
|
Several changes:
lastFetched
isn't set as this call is a) pointless as we know we need to do a full-fetch and b) pretty expensive.