-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly set the pathPrefix and assetPrefix in the pluginData #33667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Oct 25, 2021
KyleAMathews
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 !
KyleAMathews
added
type: bug
An issue or pull request relating to a bug in Gatsby
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Oct 25, 2021
I added it to the v3 backport project so it'll get done |
vladar
pushed a commit
that referenced
this pull request
Oct 27, 2021
(cherry picked from commit 168351e)
vladar
pushed a commit
that referenced
this pull request
Oct 27, 2021
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
This was referenced Jun 6, 2022
This was referenced Jun 7, 2022
This was referenced Jun 7, 2022
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve pathPrefix and assetPrefix from the config instead of the data passed in through onPostBuild which doesn't distinguish between an assetPrefix and pathPrefix
It would be nice to get this fix back ported to version 3 so assetPrefix properly works in Gatsby Cloud.