Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set the pathPrefix and assetPrefix in the pluginData #33667

Merged
merged 1 commit into from Oct 25, 2021
Merged

Properly set the pathPrefix and assetPrefix in the pluginData #33667

merged 1 commit into from Oct 25, 2021

Conversation

dmccraw
Copy link
Contributor

@dmccraw dmccraw commented Oct 25, 2021 •
edited

  • Retrieve pathPrefix and assetPrefix from the config instead of the data passed in through onPostBuild which doesn't distinguish between an assetPrefix and pathPrefix

  • It would be nice to get this fix back ported to version 3 so assetPrefix properly works in Gatsby Cloud.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 25, 2021
KyleAMathews
KyleAMathews approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@KyleAMathews KyleAMathews added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 25, 2021
@KyleAMathews KyleAMathews added this to To cherry-pick in V3 Release Hotfixes via automation Oct 25, 2021
@KyleAMathews
Copy link
Contributor

I added it to the v3 backport project so it'll get done

@dmccraw dmccraw merged commit 168351e into master Oct 25, 2021
@dmccraw dmccraw deleted the dmccraw/send-proper-path-prefix branch October 25, 2021 22:07
@gatsbybot gatsbybot mentioned this pull request Oct 27, 2021
Merged
vladar pushed a commit that referenced this pull request Oct 27, 2021
@vladar
Properly set the pathPrefix and assetPrefix in the pluginData (#33667)
832ff1d 
(cherry picked from commit 168351e)
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Oct 27, 2021
vladar pushed a commit that referenced this pull request Oct 27, 2021
Properly set the pathPrefix and assetPrefix in the pluginData (#33667) (
6bfd0f1 
#33702)

(cherry picked from commit 168351e)

Co-authored-by: Dustin McCraw <dustin.mccraw@gatsbyjs.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes Oct 27, 2021
@vladar vladar moved this from Backported to Published in V3 Release Hotfixes Oct 28, 2021
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
@wardpeet
Properly set the pathPrefix and assetPrefix in the pluginData (gatsby…
39a2625 
…js#33667)
axe312ger pushed a commit that referenced this pull request Nov 9, 2021
@axe312ger
Properly set the pathPrefix and assetPrefix in the pluginData (#33667)
47d9d5c
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 6, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 6, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 6, 2022
Open
This was referenced Jun 6, 2022
Open
Open
This was referenced Jun 7, 2022
Open
Open
This was referenced Jun 7, 2022
Open
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Jun 7, 2022
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 15, 2024
Open
Open
This was referenced Apr 15, 2024
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
This was referenced Apr 15, 2024
Open
Open
Open
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmccraw @KyleAMathews