-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): null check for context #35096
Merged
LekoArts
merged 2 commits into
gatsbyjs:master
from
aardling:context-resolver-undefined
Mar 11, 2022
Merged
fix(gatsby): null check for context #35096
LekoArts
merged 2 commits into
gatsbyjs:master
from
aardling:context-resolver-undefined
Mar 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Mar 10, 2022
LekoArts
added
topic: core
Relates to Gatsby's core (e.g. page loading, reporter, state machine)
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Mar 10, 2022
Can you push an empty commit? For some reason the CI didn't trigger a run |
it doesn't look like the windows_unit_tests failing has anything to do with this PR? |
LekoArts
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced May 13, 2024
This was referenced May 14, 2024
This was referenced May 14, 2024
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've ran into a case where
context
was undefined resulting in:there was a check on
if (context?.tracer)
already but not on thetelemtryResolverTimings
Documentation
No updates need