chore(starters): Migrate starters to Head API #36234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
marvinjude
added
topic: DX
marvinjude
changed the title
marvinjude
changed the title
imjoshin
reviewed
Jul 25, 2022
tyhopp
reviewed
Jul 26, 2022
LekoArts
suggested changes
Jul 26, 2022
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
DSchau
reviewed
Jul 26, 2022
| @@ -65,6 +63,8 @@ const BlogIndex = ({ data, location }) => { | |||
|
|
|||
| export default BlogIndex | |||
|
|
|||
| export const Head = () => <Seo title="All posts" /> | |||
There was a problem hiding this comment.
Really nice and simple refactor / API here @marvinjude. Nicely done.
DSchau
reviewed
Jul 26, 2022
| @@ -4,4 +4,6 @@ | |||
| * See: https://www.gatsbyjs.com/docs/ssr-apis/ | |||
| */ | |||
|
|
|||
| // You can delete this file if you're not using it | |||
| exports.onRenderBody = ({ setHtmlAttributes }) => { | |||
| setHtmlAttributes({ lang: `en` }) | |||
There was a problem hiding this comment.
Should or have we documented this? (I've typically myself set the html attributes with the Helmet component, so it's possible that's still documented somewhere!)
The context: it's a reasonably common use case for folks, and if I recall, it's one thing that Lighthouse recommends too.
There was a problem hiding this comment.
LekoArts
approved these changes
Jul 26, 2022
LekoArts
suggested changes
Jul 26, 2022
Yep! It's all good now |
LekoArts
approved these changes
Jul 27, 2022
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Starters to Head API
[sc-53425]