Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-parcel-config): Re-Add JSON transformer #36748

Merged
merged 1 commit into from
Oct 5, 2022
Merged

feat(gatsby-parcel-config): Re-Add JSON transformer #36748

merged 1 commit into from
Oct 5, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Oct 5, 2022 •
edited

Description

In #36583 I removed a bunch of stuff from our Parcel config, including the JSON transformer. While technically speaking Node.js doesn't support / has really weird syntaxes to import JSON in ESM, it's easier to just re-add it and have it as a QoL improvement for people.

@LekoArts LekoArts mentioned this pull request Oct 5, 2022
Merged
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 5, 2022
@LekoArts LekoArts added this to To cherry-pick in V4 Release hotfixes via automation Oct 5, 2022
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 5, 2022
@LekoArts LekoArts mentioned this pull request Oct 5, 2022
Closed
2 tasks
@imjoshin imjoshin merged commit 5e639b8 into master Oct 5, 2022
@imjoshin imjoshin deleted the parcel-json-transformer branch October 5, 2022 14:54
@gatsbybot gatsbybot mentioned this pull request Oct 6, 2022
Merged
LekoArts added a commit that referenced this pull request Oct 6, 2022
@LekoArts
feat(gatsby-parcel-config): Re-Add JSON transformer (#36748)
6db5518 
initial

(cherry picked from commit 5e639b8)
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Oct 6, 2022
LekoArts added a commit that referenced this pull request Oct 6, 2022
@gatsbybot @LekoArts
feat(gatsby-parcel-config): Re-Add JSON transformer (#36748) (#36752)
7f5aec0 
Co-authored-by: Lennart <lekoarts@gmail.com>
@LekoArts LekoArts moved this from Backport PR opened to Published in V4 Release hotfixes Oct 6, 2022
@LekoArts
Copy link
Contributor Author

LekoArts commented Oct 6, 2022

Published in

Successfully published:
 - gatsby-parcel-config@0.15.1
 - gatsby@4.24.2

Khaledgarbaya pushed a commit that referenced this pull request Oct 7, 2022
@LekoArts @Khaledgarbaya
feat(gatsby-parcel-config): Re-Add JSON transformer (#36748)
1d649bf 
initial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoshin imjoshin imjoshin approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
V4 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LekoArts @imjoshin