perf: normalize engines static query context #37764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: LekoArts <lekoarts@gmail.com>
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: render-mode
pieh
commented
Mar 20, 2023
LekoArts
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This "splits" currently generated
sq-context(which are combined static query results for each page and slice template) into individual static query results. Some filtering is done to only collect static queries that are actually used in page templates that will be used by engines (SSR/DSG). Currently filtering is not done for slice templates as it's not that straight forward to do with slice overrides and this PR as-is is already potentially improving size of generated engines. Slice templates filtering is potential follow up to this if this will be not enough.Documentation
Tests
Related Issues
Related to #37713