fix(gatsby-plugin-sharp): don't serve static assets that are not result of currently triggered deferred job #37796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt of currently triggered deferred job
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
LekoArts
added
the
topic: media
LekoArts
approved these changes
Mar 29, 2023
pieh
deleted the
fix/gatsby-plugin-sharp-serving-assets-other-than-job-result
branch
pieh
added a commit
that referenced
this pull request
Mar 29, 2023
…lt of currently triggered deferred job (#37796) (#37802) * fix(gatsby-plugin-sharp): don't serve static assets that are not result of currently triggered deferred job (#37796) * add tests * fix(gatsby-plugin-sharp): don't serve static assets that are not result of currently triggered deferred job (cherry picked from commit 6539860) * ignore browserlist update prompt * fix ignore --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
This was referenced Apr 19, 2023
This was referenced Apr 19, 2023
This was referenced Apr 19, 2023
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lazy images express handler should not handle serving assets other than result of currently triggered job as we do have
express.staticfor that earlier in request handlers chainDocumentation
Tests
Added e2e tests for dev and prod runtime
Related Issues