[gatsby-source-wordpress] add option for custom normalizer (#3450) #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for using-drupal ready! Built with commit 4f262d7 |
|
Deploy preview for gatsbygram ready! Built with commit 4f262d7 |
pieh
requested changes
Jun 1, 2018
| @@ -97,6 +97,10 @@ plugins: [ | |||
| // Example: `["/*/*/comments", "/yoast/**"]` will exclude routes ending in `comments` and | |||
| // all routes that begin with `yoast` from fetch. | |||
| excludedRoutes: ["/*/*/comments", "/yoast/**"], | |||
| // use a custom normalizer which is applied after the built-in ones. | |||
There was a problem hiding this comment.
This description makes assumption that user is familiar with gatsby-source-wordpress codebase and what "normalizer" means in this context. It would be good to expand a little bit on when/why this should be used.
There was a problem hiding this comment.
You're absolutely right! Added a section to the Readme with a use case and example.
pieh
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic version to use a custom normalizer function like discussed in #3450.
We pass an object to that function, which contains the already normalized entities and also other helpful functions like
createNodeId,store,cacheand the plugin's options from gatsby-config.js as well.