don't run debouncedCreatePages on DELETE_NODE

[pieh]

Fixes #7300

Problem with running debouncedCreatePages is it assumes we can finish all processing in 100ms which is not always the case. In #7300 it was causing to run createPages before slug was attached, so query inside component would never find actual node because it would try to find node with slug === null

here's my debugy output from before the change:

info changed file at D:\dev\i7300\src\post\tile-layouts.mdx
deleting createMdxNode 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
deleting createMdxNode finish 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
here's debouncedCreatePages is called --> DELETE_NODE create pages
createMdxNode 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
createMdxNode finish 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
createPages (slug isn't added, we are passing null in context -> query then can't find node with null slug)
onCreateNode 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx /post/tile-layouts/
createMdxNode ADD_FIELD_TO_NODE finish 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
running query for /post/tile-layouts
running query for /
running query for Finished /post/tile-layouts
running query for Finished /

after the change (we run createPages after all processing was done):

info changed file at D:\dev\i7300\src\post\tile-layouts.mdx
deleting createMdxNode 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
deleting createMdxNode finish 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
createMdxNode 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
createMdxNode finish 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
onCreateNode 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx /post/tile-layouts/
createMdxNode ADD_FIELD_TO_NODE finish 32a0c299-deff-5812-894a-6df20be75e2d >>> Mdx
API_RUNNING_QUEUE_EMPTY create pages
createPages
running query for /post/tile-layouts
running query for /
running query for Finished /post/tile-layouts
running query for Finished /

[m-allanson]

👍

[KyleAMathews]

ahhhh!!! Yeah!!!!

All that debouncing stuff was added before I smarted up with API_RUNNING_QUEUE_EMPTY. Guess this got left around :-( and caused 100s of issues of "can't find frontmatter" and tens of thousands of forced restarts of gatsby develop sigh.

[geddski]

There is no gif that accurately portrays my excitement.

Thank you thank you thank you! Can't wait to try it.

[m-allanson]

Published as gatsby@2.0.0-beta.109

[geddski]

Confirmed that fixed it!!!!

@pieh you are a beast. Thank you so much! Oh my gosh Gatsby dev experience is amazing now.