-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more default extensions to resolve .mjs & .wasm & .json #8327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
These are all default resolvable extensions in webpack so we should add them. NPM packages are starting to ship .mjs files which people are running into trouble with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from my comment.
my only concern here is it dramatically increases the pathnames webpack has to stat to resolve one file...my hunch would be to only support what Node does out of the box |
Agreed — other than wasm (and jsx), this is now what node support out of the box. |
Yarn registry killed appveyor :-| merging as otherwise is working. |
This doesn't seem to fix #7581 unless: actions.setWebpackConfig({
module: {
rules: [
{
test: /\.mjs$/,
type: 'javascript/auto',
},
],
},
}) |
Hmm ok. Could you open a new issue with a reproduction? |
fixes #8246
fixes #7581