Skip to content

Conversation

tsubakiky
Copy link
Collaborator

@tsubakiky tsubakiky commented Jul 5, 2025

This pull request introduces several changes across multiple files to enhance functionality, fix typos, and improve code quality. The most significant updates include adding new Makefile commands for formatting and linting, fixing a recurring typo in the get_compression_from_name function and related usages, and adding a module-level docstring and exports in src/connect/__init__.py.

Build and Development Enhancements:

  • Makefile Updates: Added format and lint commands to streamline code formatting and linting using ruff, mypy, and pyright.

Code Quality Improvements:

  • Typo Fixes: Corrected multiple instances of the typo compresion to compression across several files, including src/connect/compression.py, src/connect/client.py, src/connect/protocol_connect/connect_client.py, and src/connect/protocol_grpc/grpc_client.py. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Documentation and Initialization:

  • Module Docstring and Exports: Added a comprehensive docstring and __all__ exports in src/connect/__init__.py to improve module documentation and clarify public API elements.

Minor Bug Fix:

  • Content Stream Fix: Corrected a bug in src/connect/content_stream.py by changing self.closed to self._closed to ensure proper attribute usage.

Configuration Updates:

  • Pyproject.toml Enhancements: Added pydocstyle configuration with the "google" convention to enforce consistent docstring styles.

@tsubakiky tsubakiky requested a review from zchee as a code owner July 5, 2025 07:38
@tsubakiky tsubakiky merged commit ced67dc into main Jul 5, 2025
4 checks passed
@tsubakiky tsubakiky deleted the typo-compress branch July 5, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant