Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot_smooth method for soap films needs some tweaking #288

Open
1 of 2 tasks
gavinsimpson opened this issue May 24, 2024 · 0 comments
Open
1 of 2 tasks

plot_smooth method for soap films needs some tweaking #288

gavinsimpson opened this issue May 24, 2024 · 0 comments
Labels
bug Something isn't working plotting

Comments

@gavinsimpson
Copy link
Owner

gavinsimpson commented May 24, 2024 •
edited
Loading

The problems are:

  • we need to evaluate the smooth evenly not over the domain spanned by the data but over the domain spanned by the boundary — needs something special for eval_smooth or spline_values I think.
  • the plot_smooth method for soap films needs + coord_fixed()
@gavinsimpson gavinsimpson added bug Something isn't working plotting labels May 24, 2024
gavinsimpson added a commit that referenced this issue Jun 28, 2024
@gavinsimpson
implement one part of #288; turn the plot for soap film smooths into …
4ce504b 
…an isotropic one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working plotting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavinsimpson