Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gojsondiff compilation error #34

Merged
merged 1 commit into from
Jan 8, 2017
Merged

Fix gojsondiff compilation error #34

merged 1 commit into from
Jan 8, 2017

Conversation

yudai
Copy link
Contributor

@yudai yudai commented Jan 8, 2017

Closes #33

Sorry for the breaking change. I'll introduce the semantic versioning later.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.003%) to 97.165% when pulling e55dad9 on yudai:master into dc92986 on gavv:master.

@ghost
Copy link

ghost commented Jan 8, 2017

I just pushed a whole vendor folder to the Iris' repository because of this xD

@gavv gavv merged commit e55dad9 into gavv:master Jan 8, 2017
@gavv
Copy link
Owner

gavv commented Jan 8, 2017

Thanks!

@gavv
Copy link
Owner

gavv commented Jan 8, 2017

Sorry for the breaking change. I'll introduce the semantic versioning later.

Great, waiting for this.

@gavv gavv added this to the v1 milestone Jan 8, 2017
@yudai
Copy link
Contributor Author

yudai commented Jan 9, 2017

Added a tag with 1.0.0 to the repo. No breaking change will be introduced to this major version.
Thanks!

@mattes
Copy link
Contributor

mattes commented Jan 9, 2017

Thanks @yudai

ghost pushed a commit to kataras/go-sessions that referenced this pull request Jan 10, 2017
ghost pushed a commit to kataras/iris that referenced this pull request Jan 10, 2017
WingGao pushed a commit to WingGao/iris that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants