Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignition.dsl: enable CI for dome branches #299

Merged
merged 3 commits into from
Oct 4, 2020
Merged

ignition.dsl: enable CI for dome branches #299

merged 3 commits into from
Oct 4, 2020

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Oct 1, 2020

We have release branches now for dome, so enable CI.

Signed-off-by: Steve Peters scpeters@openrobotics.org

@scpeters
ignition.dsl: enable CI for dome branches
76c4cd6 
We have release branches now for dome, so enable CI.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

scpeters commented Oct 1, 2020

Build Status https://build.osrfoundation.org/job/_dsl_ignition/1031/

@j-rivero
Copy link
Contributor

j-rivero commented Oct 1, 2020

Build Status https://build.osrfoundation.org/job/_dsl_ignition/1031/

I just hit the cancel button on this one. Sorry but the buildfarm is pretty busy these days and there is another gazebo9 release on the queue so I would prefer to delay these changes until the weekend or next week if possible. Otherwise there will be a good bunch of jobs in the queue which is no good for the RAM consumption.

@scpeters
Copy link
Contributor Author

scpeters commented Oct 1, 2020

good point, thanks for stopping it quickly

@j-rivero
Copy link
Contributor

j-rivero commented Oct 1, 2020

good point, thanks for stopping it quickly

I'm changing this to a draft by now, please reopen it or ping me next week I don't have merged this before

@j-rivero j-rivero marked this pull request as draft October 1, 2020 16:56
@scpeters
Update dome collection view with stable branches
c3d58dc 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Disable more xenial CI jobs
5efaade 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

scpeters commented Oct 3, 2020

@j-rivero should we test this over the weekend?

@j-rivero j-rivero marked this pull request as ready for review October 3, 2020 22:34
j-rivero
j-rivero approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not see any problem in the changes. Let's give a run during the weekend and see if more changes are needed.

@j-rivero j-rivero merged commit 8452faa into master Oct 4, 2020
@j-rivero j-rivero deleted the dome_ci branch October 4, 2020 10:06
@chapulina chapulina mentioned this pull request May 11, 2021
Closed
@chapulina chapulina mentioned this pull request Nov 30, 2021
Open
@azeey azeey mentioned this pull request Jul 28, 2023
Closed
82 tasks
@azeey azeey mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @j-rivero