Skip to content

[Jetty] Migrate Windows source installation to use Pixi #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 11, 2025
Merged

[Jetty] Migrate Windows source installation to use Pixi #625

merged 12 commits into from
Sep 11, 2025

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 9, 2025

🎉 New feature

The PR migrates the current documentation for installing windows from sources for the Jetty distribution. Instead of using miniforge installer and conda workspaces, the PR makes the use of Pixi.

Summary

Pixi is now being used by part of the members of the Gazebo core team and is handling the buildfarm CI. The same conda-forge packages are used but controlled by a Pixi configuration file so every time the same set of packages are installed.

The PR includes the set of QT environment variables to workaround the bug in
conda-forge/qt-main-feedstock#275.

Some related changes that can/needs to be merged with this PR:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

@j-rivero
WIP: migrate to use Pixi instructions
4b01400 
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
@j-rivero
Include the pixi shell and vcs using URL
5486f6f 
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
@j-rivero
Include QT environment variables
c398709 
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
@j-rivero j-rivero requested a review from azeey as a code owner September 9, 2025 14:56
This was referenced Sep 9, 2025
Open
Open
@j-rivero j-rivero mentioned this pull request Sep 9, 2025
Closed
knmcguire
knmcguire reviewed Sep 10, 2025
View reviewed changes
Copy link
Contributor

@knmcguire knmcguire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will make things so much easier!

I'm currently busy in rebuilding a fresh workspace with these instructions just to make sure that everything works, but I already had some comments on the instructions itself.

jetty/install_windows_src.md Outdated
option is to follow the Pixi installer instructions.

```bash
powershell -ExecutionPolicy ByPass -c "irm -useb https://pixi.sh/install.ps1 | iex"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before it said " follow the Pixi installer instructions". Is it a good idea to actually have the install commands here? Isn't it better to refer to the pixi install instructions directly (might be more future proof). ROS 2 has that in their latest windows source installation instructions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better idea yes, replaced.

@knmcguire
Copy link
Contributor

And, I've been successful in running the standalone gz sim based on these instructions! See here gazebosim/gazebo_test_cases#2259 (comment)

j-rivero and others added 6 commits September 10, 2025 17:45
@j-rivero @knmcguire
Apply suggestion from @knmcguire
f949447 
Co-authored-by: Kimberly N. McGuire <kimberleymcguire@gmail.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero @knmcguire
Apply suggestion from @knmcguire
9750187 
Co-authored-by: Kimberly N. McGuire <kimberleymcguire@gmail.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero @knmcguire
Apply suggestion from @knmcguire
d3b1a78 
Co-authored-by: Kimberly N. McGuire <kimberleymcguire@gmail.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero @knmcguire
Apply suggestion from @knmcguire
f78d95e 
Co-authored-by: Kimberly N. McGuire <kimberleymcguire@gmail.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Update install_windows_src.md
850900a 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Replace Pixi install instructions
56866a6 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Copy link
Contributor Author

And, I've been successful in running the standalone gz sim based on these instructions! See here gazebosim/gazebo_test_cases#2259 (comment)

Thanks @knmcguire for all the testing and fixed. I applied all them.

azeey
azeey approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor formatting comments. Thanks!

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 10, 2025
j-rivero and others added 2 commits September 11, 2025 18:07
@j-rivero @azeey
Update jetty/install_windows_src.md
1838d04 
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero @azeey
Update jetty/install_windows_src.md
314b6cb 
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Copy link
Contributor Author

Just a couple of minor formatting comments. Thanks!

great thanks !

@j-rivero j-rivero merged commit 6a44f4a into master Sep 11, 2025
5 checks passed
@j-rivero j-rivero deleted the jrivero/pixi_src_install branch September 11, 2025 16:13
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

+1 more reviewer

@knmcguire knmcguire knmcguire left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🪵 jetty
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @knmcguire @azeey