Make CollectionIdentifier::UniqueName consistent #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were relying on UniqueName to hold a Url. UniqueName was updated to generate filesystem-safe paths for both Linux and Windows, so it no longer holds a valid Url. This adds a peer method to also retrieve the Url of the Model/World/Collection Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
ahcorde
approved these changes
Jul 24, 2024
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
force-pushed
the
mjcarroll/collection_identifier
branch
from
295ec1c
to
8da515e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelIdentifierandWorldIdentifierwere updated in #376, we need to make it consitent across all of theIdentifierclasses.