-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Plotting Crash #124
Merged
chapulina
merged 21 commits into
gazebosim:master
from
AmrElsersy:plotting-interface-time-tick
Sep 14, 2020
Merged
Fix Plotting Crash #124
chapulina
merged 21 commits into
gazebosim:master
from
AmrElsersy:plotting-interface-time-tick
Sep 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
…/AmrElsersy/ign-gui into plotting-interface-time-tick
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
…/AmrElsersy/ign-gui into plotting-interface-time-tick
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
chapulina
force-pushed
the
plotting-interface-time-tick
branch
from
September 14, 2020 15:46
70cfaee
to
4bdf559
Compare
chapulina
suggested changes
Sep 14, 2020
chapulina
added
beta
Targeting beta release of upcoming collection
bug
Something isn't working
🔮 dome
Ignition Dome
labels
Sep 14, 2020
…/AmrElsersy/ign-gui into plotting-interface-time-tick
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just pushed a little change in d65abee to use make_shared
instead of new
, which is slightly more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Plotting Crash due to closing Plotting ign-gui plugin
@chapulina
@claireyywang