Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plotting Crash #124

Merged
merged 21 commits into from
Sep 14, 2020
Merged

Conversation

AmrElsersy
Copy link
Contributor

@AmrElsersy AmrElsersy commented Sep 13, 2020

Fix Plotting Crash due to closing Plotting ign-gui plugin

@chapulina
@claireyywang

AmrElsersy and others added 17 commits August 27, 2020 12:02
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
src/PlottingInterface.cc Outdated Show resolved Hide resolved
src/plugins/plotting/TransportPlotting.cc Outdated Show resolved Hide resolved
@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working 🔮 dome Ignition Dome labels Sep 14, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just pushed a little change in d65abee to use make_shared instead of new, which is slightly more efficient.

@chapulina chapulina merged commit 03466fc into gazebosim:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants