Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sky tag to the new Scene3D #230

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Add sky tag to the new Scene3D #230

merged 2 commits into from
Jun 10, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 8, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Allow to load sky using the <sky> tag

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde
Add sky tag to the new Scene3D
680a8c2 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from iche033 June 8, 2021 10:48
@ahcorde ahcorde requested a review from chapulina as a code owner June 8, 2021 10:48
jennuine
jennuine reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, missing documentation for a couple items

src/plugins/scene3d/Scene3D.hh Show resolved Hide resolved
src/plugins/scene3d/Scene3D.hh Show resolved Hide resolved
@ahcorde
Update docs
68e1cc4 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 42e071f into chapulina/6/new_scene Jun 10, 2021
@ahcorde ahcorde deleted the ahcorde/6/new_scene_sky branch June 10, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@iche033 iche033 Awaiting requested review from iche033

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @jennuine