Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support particle_emitters in the websocket server #104

Merged
merged 4 commits into from
Apr 12, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 30, 2021

🎉 New feature

Summary

Adds a call to service provided by ParticleEmitter2 in the websocket plugin. This call supports returning the list of particle emitters to a client, such as gz3d.

This functionality will be deprecated in Ignition Fortress. Users will be able to rely on the Scene message from Ignition Fortress on.

This is part of a series of pull requests designed to support particle emitter in gz3d.
See also:

Test it

Run the web application using both:

  1. https://gitlab.com/ignitionrobotics/web/app/-/merge_requests/113
  2. https://gitlab.com/ignitionrobotics/web/gz3d/-/merge_requests/44

Using websocket.ign and fog.sdf from https://gist.github.com/nkoenig/cd3f5cbf69be97f04190e3cfaa155423:

  1. ign launch -v 4 websocket.ign
  2. To to the /visualize route on the web app, and click connect.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Mar 31, 2021
@nkoenig nkoenig requested a review from iche033 April 5, 2021 21:30
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, I was able to see the particles in the web app

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #104 (301073d) into ign-launch3 (88c2355) will not change coverage.
The diff coverage is n/a.

❗ Current head 301073d differs from pull request most recent head 952ae1b. Consider uploading reports for the commit 952ae1b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch3     #104   +/-   ##
============================================
  Coverage        30.24%   30.24%           
============================================
  Files                3        3           
  Lines              734      734           
============================================
  Hits               222      222           
  Misses             512      512           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c2355...952ae1b. Read the comment docs.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig merged commit 9201695 into ign-launch3 Apr 12, 2021
@nkoenig nkoenig deleted the particle_emitters branch April 12, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants