Use the new GUI API of ign-gazebo #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
nkoenig
approved these changes
Apr 23, 2020
chapulina
suggested changes
Apr 24, 2020
There was a problem hiding this comment.
Works for me, thank you for reducing duplication.
We should bump the required ign-gazebo version before this is merged.
While reviewing this, I noticed that the application doesn't terminate when the window is closed. I assume this is on purpose, because I could reproduce the behaviour on a released branch. But I verified that the GazeboGui plugin is being properly terminated on this branch 👍
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
chapulina
approved these changes
Apr 27, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for saving worlds to SDFormat from the GUI.