Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed material Python interface #248

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 23, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

This PR builds on top #234 and fixes the issue related with the material

@LolaSegura do you have some time to review it ?

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (LolaSegura/add_material-type_material@30d473f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                           Coverage Diff                            @@
##             LolaSegura/add_material-type_material     #248   +/-   ##
========================================================================
  Coverage                                         ?   99.21%           
========================================================================
  Files                                            ?       65           
  Lines                                            ?     6089           
  Branches                                         ?        0           
========================================================================
  Hits                                             ?     6041           
  Misses                                           ?       48           
  Partials                                         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d473f...601d189. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Sep 24, 2021
@ahcorde ahcorde merged commit c216a05 into LolaSegura/add_material-type_material Oct 6, 2021
@ahcorde ahcorde deleted the ahcorde/add_material-type_material branch October 6, 2021 18:40
scpeters pushed a commit that referenced this pull request Oct 7, 2021
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>

* Fixed material Python interface (#248)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants