-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 1D kinematic state message. #352
Conversation
Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: jrutgeer <johan.rutgeerts@lancewood.eu>
Codecov Report
@@ Coverage Diff @@
## gz-msgs9 #352 +/- ##
=========================================
Coverage 95.41% 95.41%
=========================================
Files 10 10
Lines 1026 1026
=========================================
Hits 979 979
Misses 47 47 |
Looking at gazebosim/gz-sim#2021, I only see position and velocity being populated. Have you considered using the existing |
@azeey Good question. The initial idea for gazebosim/gz-sim#2021 was that it would publish the full kinematic state, including acceleration and jerk. However, during implementation I realized that this is not possible as the TrackController is velocity resolved (i.e. at each timestep the position and velocity are known, but the acceleration depends on the next velocity setpoint, which is not yet known). So technically it is possible to use the odometry message instead, at least for this usecase. From a semantic point of view, I think initially it feels rather strange to use the odometry message, but having given it some thought I conclude that "conveyor position and velocity" is indeed a kind of "1D odometry", and similar arguments as in this discussion hold, so it might indeed make sense to represent a 1D odometry with the existing 6D odometry message. If you follow this line of thought, I will close this PR and adapt gazebosim/gz-sim#2021 accordingly. |
Closing in favor of changing gazebosim/gz-sim#2021 to use an odometry message instead. |
🎉 New feature
Required for gazebosim/gz-sim#2021
Summary
This PR adds a message type for 1D kinematic state: