Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 1D kinematic state message. #352

Closed
wants to merge 2 commits into from
Closed

Added 1D kinematic state message. #352

wants to merge 2 commits into from

Conversation

jrutgeer
Copy link
Contributor

@jrutgeer jrutgeer commented Jun 19, 2023

🎉 New feature

Required for gazebosim/gz-sim#2021

Summary

This PR adds a message type for 1D kinematic state:

  • Position
  • Velocity
  • Acceleration
  • Jerk

jrutgeer and others added 2 commits June 20, 2023 09:26
Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: jrutgeer <johan.rutgeerts@lancewood.eu>
@mjcarroll
Copy link
Contributor

@azeey and @scpeters any other input from a physics perspective?

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #352 (0680992) into gz-msgs9 (2e7f1c6) will not change coverage.
The diff coverage is n/a.

❗ Current head 0680992 differs from pull request most recent head 073c121. Consider uploading reports for the commit 073c121 to get more accurate results

@@            Coverage Diff            @@
##           gz-msgs9     #352   +/-   ##
=========================================
  Coverage     95.41%   95.41%           
=========================================
  Files            10       10           
  Lines          1026     1026           
=========================================
  Hits            979      979           
  Misses           47       47           

@azeey
Copy link
Contributor

azeey commented Jun 20, 2023

Looking at gazebosim/gz-sim#2021, I only see position and velocity being populated. Have you considered using the existing Odometery message?

@jrutgeer
Copy link
Contributor Author

@azeey Good question. The initial idea for gazebosim/gz-sim#2021 was that it would publish the full kinematic state, including acceleration and jerk. However, during implementation I realized that this is not possible as the TrackController is velocity resolved (i.e. at each timestep the position and velocity are known, but the acceleration depends on the next velocity setpoint, which is not yet known).

So technically it is possible to use the odometry message instead, at least for this usecase.

From a semantic point of view, I think initially it feels rather strange to use the odometry message, but having given it some thought I conclude that "conveyor position and velocity" is indeed a kind of "1D odometry", and similar arguments as in this discussion hold, so it might indeed make sense to represent a 1D odometry with the existing 6D odometry message.

If you follow this line of thought, I will close this PR and adapt gazebosim/gz-sim#2021 accordingly.

@jrutgeer
Copy link
Contributor Author

Closing in favor of changing gazebosim/gz-sim#2021 to use an odometry message instead.

@jrutgeer jrutgeer closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants