Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix construction of nested models #445

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

This makes dartsim correctly handle nested models. The simulation runner may try to construct models twice (First from the root sdf::Model, and then again because the nested model is in the ECM). This will return the originally constructed model rather than creating a duplicate.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Oct 28, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 28, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linters

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #445 (17fbdeb) into gz-physics6 (96425a2) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 17fbdeb differs from pull request most recent head 6c033ac. Consider uploading reports for the commit 6c033ac to get more accurate results

@@             Coverage Diff              @@
##           gz-physics6     #445   +/-   ##
============================================
  Coverage        75.73%   75.73%           
============================================
  Files              140      140           
  Lines             7034     7039    +5     
============================================
+ Hits              5327     5331    +4     
- Misses            1707     1708    +1     
Impacted Files Coverage Δ
dartsim/src/SDFFeatures.cc 62.74% <83.33%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 924e0b4 into gz-physics6 Oct 28, 2022
@mjcarroll mjcarroll deleted the mjcarroll/fix_dartsim_nested branch October 28, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants