Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic Changelog #678

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Ionic Changelog #678

merged 3 commits into from
Aug 27, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebo-tooling/release-tools#1092

Summary

Update changelog for gz-physics 8.0.0, with an unspecified release date.

Test it

Compare to gz-physics7_7.3.0...main

Note: I excluded the following Harmonic PRs that have not been released as of 7.3.0 since they will be released in Harmonic. Please advise if I should add them.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@azeey
Copy link
Contributor

azeey commented Aug 26, 2024

I think we should include them. It'll make it easier to create the Gazebo Ionic release notes that includes all development that happened this year, not just the ones that went into the main branches. One way I'm thinking of it is if we did all our new development on the main branches, but backported to older versions, we would include these changes in the main Changelog right?

@scpeters
Copy link
Member Author

I think we should include them. It'll make it easier to create the Gazebo Ionic release notes that includes all development that happened this year, not just the ones that went into the main branches. One way I'm thinking of it is if we did all our new development on the main branches, but backported to older versions, we would include these changes in the main Changelog right?

it depends on what we want the Changelog to represent:

  • should it represent the work we've done in the past year? in which case we should include all development done since the Harmonic release regardless of branch
  • OR should it represent the features only available on Ionic so people know what they are missing if they don't upgrade. In which case we wouldn't include features that were backported

I've been constructing changelogs based on the second approach but am willing to revise them if we agree that the first approach is preferred

@azeey
Copy link
Contributor

azeey commented Aug 26, 2024

Okay, per our discussion in the weekly meeting, the Changelog for a major release should represent changes from the last release of the stable version. This version should also be explicitly stated at the beginning of the Changelog.

@scpeters
Copy link
Member Author

Okay, per our discussion in the weekly meeting, the Changelog for a major release should represent changes from the last release of the stable version. This version should also be explicitly stated at the beginning of the Changelog.

I've updated our changelog script in gazebo-tooling/release-tools#1175 to print the baseline

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

I've updated the changelog to add a baseline and some missing entries and also set the VERSION_SUFFIX to pre1 so we can make the prerelease without another pull request

@scpeters scpeters merged commit ff3c531 into main Aug 27, 2024
8 of 9 checks passed
@scpeters scpeters deleted the scpeters/ionic_changelog branch August 27, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants