Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance drops significantly when echoing the /world/shapes/dynamic_pose/info topic #743

Closed
adlarkin opened this issue Apr 6, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request performance Runtime performance

Comments

@adlarkin
Copy link
Contributor

adlarkin commented Apr 6, 2021

Desired behavior

@iche033 discovered that echoing the /world/shapes/dynamic_pose/info topic for a world with a lot of shapes results in a significant RTF decrease. On my machine, I found that my RTF dropped from 90% to 10% when I started to echo this topic (using TPE, and running headless).

Alternatives considered

TBD

Implementation suggestion

It seems like this function is being called, which causes the slow down. So, I think that we should try to optimize this method.

Additional context

At first glance, it appears as if this could be related to #711, since the method linked above uses a lot of Each calls.

@adlarkin adlarkin added enhancement New feature or request performance Runtime performance labels Apr 6, 2021
@adlarkin adlarkin self-assigned this Apr 6, 2021
@adlarkin
Copy link
Contributor Author

adlarkin commented Sep 2, 2021

@iche033 I think that we can close this now that #856 is merged. If you look at the new performance testing numbers in the PR description of #856, the /world/shapes/dynamic_pose/info RTF is a lot better now. If you think that the new performance of this topic with #856 is good enough, let me know, and I will close this.

@iche033
Copy link
Contributor

iche033 commented Sep 2, 2021

sounds good, closing

@iche033 iche033 closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Runtime performance
Projects
None yet
Development

No branches or pull requests

2 participants