-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shapes plugin #107
Add shapes plugin #107
Conversation
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: John Shepherd <john@openrobotics.org>
…cs/ign-gazebo into add_shapes_plugin
Fixed in dd864dd |
Ready for another iteration |
Signed-off-by: John Shepherd <john@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo2 #107 +/- ##
==============================================
Coverage ? 62.38%
==============================================
Files ? 123
Lines ? 6091
Branches ? 0
==============================================
Hits ? 3800
Misses ? 2291
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new mouse hover events works great
I only have a couple comments left. Otherwise looks good to me.
Signed-off-by: John Shepherd <john@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Signed-off-by: John Shepherd <john@openrobotics.org>
* Add shapes plugin (#107) Signed-off-by: John Shepherd <john@openrobotics.org> * Add option to suppress warning about missing child model (#132) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Support multi entity spawn (#146) * Support multi entity spawn Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added more documentation Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Bump ign-msgs version to 4.9 (#148) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Revert silly mistake Signed-off-by: Nate Koenig <nate@openrobotics.org> * ign-msgs 5.3 dependency Signed-off-by: Nate Koenig <nate@openrobotics.org> * Bump minor version Signed-off-by: Nate Koenig <nate@openrobotics.org> * Changelog Signed-off-by: Nate Koenig <nate@openrobotics.org> * RawPose Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John <john@openrobotics.org> Co-authored-by: Addisu Taddese <addisu@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
This PR makes use of ign-gazebo#95 so that PR will need to be merged before this one (it doesn't have to be, but I thought a separate PR for that functionality would be better for visibility and documentation purposes.There are a few things I made "prototypes" of that I would like to have looked and discussed for improvement:
UniqueId()
HandleModelPlacement()
good/could there be a better way to handle the mouse events here?There's currently a bug with this addition messing with the button pressing functionalities - I'll take a closer look at this soonResolves #81