Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check RGBD camera sensor connection #1513

Merged
merged 1 commit into from Jun 2, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 2, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

馃 Bug fix

Summary

Follow up to pull request #1480. RGBD camera was missing from the list of sensors. We added a warning to catch sensors missing from the list but unfortunately it didn't catch this because the RGBD camera was cast to a CameraSensor and the incorrect HasConnection call was invoked. This should not happen once the todo note is addressed in Garden.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@osrf-triage osrf-triage added this to Inbox in Core development Jun 2, 2022
@chapulina chapulina added the 馃彲 fortress Ignition Fortress label Jun 2, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #1513 (7eb7ddd) into ign-gazebo6 (62272db) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-gazebo6    #1513      +/-   ##
===============================================
- Coverage        33.58%   33.42%   -0.17%     
===============================================
  Files               44       45       +1     
  Lines             2260     2271      +11     
===============================================
  Hits               759      759              
- Misses            1501     1512      +11     
Impacted Files Coverage 螖
...ins/component_inspector/qrc_ComponentInspector.cpp 100.00% <0.00%> (酶)
...ugins/component_inspector/moc_SystemPluginInfo.cpp 0.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b26a573...7eb7ddd. Read the comment docs.

@iche033 iche033 merged commit 80cf7e8 into ign-gazebo6 Jun 2, 2022
@iche033 iche033 deleted the rgbd_sensor_udpate branch June 2, 2022 20:37
Core development automation moved this from In review to Done Jun 2, 2022
chapulina added a commit that referenced this pull request Jun 8, 2022
* Check RGBD camera sensor connection (#1513)

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* Fix regression with camera sensors not using the background color set in `<scene>` (#1515)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* Rename ignition to gz in #1519.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

Co-authored-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 mentioned this pull request Jun 8, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彲 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants