Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang warning from Thruster plugin #1540

Merged
merged 2 commits into from Jun 17, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Just fixing a small warning that was introduced in #1495.

See https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo6-homebrew-amd64/100/clang/

'PostUpdate' overrides a member function but is not marked 'override'

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added bug Something isn't working macOS macOS support 🏯 fortress Ignition Fortress labels Jun 16, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jun 16, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1540 (acc8da9) into ign-gazebo6 (c4dca78) will not change coverage.
The diff coverage is n/a.

❗ Current head acc8da9 differs from pull request most recent head bda2e36. Consider uploading reports for the commit bda2e36 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1540   +/-   ##
============================================
  Coverage        64.03%   64.03%           
============================================
  Files              316      316           
  Lines            25462    25462           
============================================
  Hits             16304    16304           
  Misses            9158     9158           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4dca78...bda2e36. Read the comment docs.

@chapulina chapulina merged commit 3f56166 into ign-gazebo6 Jun 17, 2022
@chapulina chapulina deleted the chapulina/6/clang_warning branch June 17, 2022 16:25
Core development automation moved this from In review to Done Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress macOS macOS support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants