-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pose for TransformControl with GzPose #1642
base: ign-gazebo3
Are you sure you want to change the base?
Conversation
Signed-off-by: youhy <haoyuan2019@outlook.com>
73bb939
to
2f11a66
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1642 +/- ##
============================================
Coverage 78.03% 78.03%
============================================
Files 255 255
Lines 15082 15082
============================================
Hits 11769 11769
Misses 3313 3313 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with allowing degrees in GzPose
!
The top of each spin box is still cut off. I saw in 5fd186e the width was adjusted but it's most likely the height that needs to be updated.
Also, I think we should revert the width so that only 2 decimal places are showing (like how it was before) but this is only my preference/opinion. I'll leave it up to you to decide.
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@jennuine The width and height both worked for me but didn't work for you. So there is no way I know what size would work for you and the only thing I can do is to increase the height and width a bit. About the precision, I doubt if we can have 2 decimals without editing GzPose again. So let's just keep it 4 decimals for now. |
This is looking good @AzulRadio but requires a |
Moving this to TODO to focus on the Garden release.
|
Signed-off-by: youhy haoyuan2019@outlook.com
New feature
Summary
As title. The behavior should be exactly the same as before.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.