Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SensorTopic component to rendering sensors #1908

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 24, 2023

🎉 New feature

Closes #85

Summary

The SensorTopic component is already available for non-rendering sensors (e.g. imu, force-torque, etc). This PR adds the component to rendering sensors, i.e. all sensors managed by the sensors system. The SensorTopic components stores the topic published by the sensor.

Note that rendering sensors may publish more than one topics, e.g. <prefix>/image and <prefix>/camera_info. In this case it'll only store the <prefix>/image topic.

Test it

Run the INTEGRATION_sensor_system test.

Alternative,

  1. launch sensors_demo.sdf world, ign gazebo -v 4 sensors_demo.sdf
  2. Go to the Entity Tree gui plugin on the right, and expand any one of the sensor models and its link, then click on a sensor entity to see the new SensorTopic component in the Component Inspector

sensor_topic

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Feb 24, 2023
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1908 (b75d537) into ign-gazebo6 (29c13bf) will increase coverage by 0.03%.
The diff coverage is 96.22%.

❗ Current head b75d537 differs from pull request most recent head 66ddbe5. Consider uploading reports for the commit 66ddbe5 to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo6    #1908      +/-   ##
===============================================
+ Coverage        64.79%   64.83%   +0.03%     
===============================================
  Files              322      323       +1     
  Lines            26398    26429      +31     
===============================================
+ Hits             17105    17135      +30     
- Misses            9293     9294       +1     
Impacted Files Coverage Δ
include/ignition/gazebo/components/Component.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 98.03% <95.74%> (-0.67%) ⬇️
src/ComponentFactory.cc 100.00% <100.00%> (ø)
src/rendering/RenderUtil.cc 39.70% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Feb 27, 2023
@iche033 iche033 merged commit 472f7e5 into ign-gazebo6 Feb 27, 2023
Core development automation moved this from In review to Done Feb 27, 2023
@iche033 iche033 deleted the rendering_sensor_topic branch February 27, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants