Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ruby commands on Windows #402

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Oct 20, 2023

🦟 Bug fix

Fixes #28

Summary

Make sure to add_subdirectory(cmd) on Windows. This requires generating the .rb and .yaml files to folders unique to $<CONFIG>.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #402 (e1371fc) into gz-msgs10 (edd9632) will not change coverage.
The diff coverage is n/a.

❗ Current head e1371fc differs from pull request most recent head 3d92998. Consider uploading reports for the commit 3d92998 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #402   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1172     1172           
==========================================
  Hits            1140     1140           
  Misses            32       32           

@Voldivh Voldivh marked this pull request as ready for review October 21, 2023 00:23
@Voldivh Voldivh requested a review from caguero as a code owner October 21, 2023 00:23
@ahcorde ahcorde merged commit 3d7793f into gz-msgs10 Oct 23, 2023
14 checks passed
@ahcorde ahcorde deleted the voldivh/win_install_cmd branch October 23, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants