Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve modularity of ign/ros publisher tests #194

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Improve modularity of ign/ros publisher tests #194

merged 3 commits into from
Jan 5, 2022

Conversation

mjcarroll
Copy link
Collaborator

Builds on #192 and #193, adding the same modularity to the integration tests.

@osrf-triage osrf-triage added this to Inbox in Core development Dec 22, 2021
@mjcarroll mjcarroll self-assigned this Dec 22, 2021
@mjcarroll mjcarroll added the ROS 2 ROS 2 label Dec 22, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Dec 22, 2021
@mjcarroll mjcarroll force-pushed the ros2_tu_improvements_static branch 2 times, most recently from 945d2e8 to 3a16846 Compare December 23, 2021 21:04
Base automatically changed from ros2_tu_improvements_static to ros2 December 23, 2021 22:25
@chapulina
Copy link
Contributor

Ok, last one! Just need to fix conflicts

@chapulina
Copy link
Contributor

Actually let's wait until #187 is merged to update this one, otherwise it will need 2 updates

@mjcarroll
Improve modularity of ign/ros publisher tests
3e81911 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Update for light messages
a81e55e 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
chapulina
chapulina approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just have some small nits. The header split could come in a separate PR if needed

ros_ign_bridge/test/utils/ign_test_msg.hpp Outdated Show resolved Hide resolved
ros_ign_bridge/test/utils/ros_test_msg.hpp Show resolved Hide resolved
ros_ign_bridge/test/utils/ros_test_msg.hpp Show resolved Hide resolved
@chapulina chapulina changed the base branch from ros2 to galactic January 5, 2022 00:39
@chapulina chapulina changed the base branch from galactic to ros2 January 5, 2022 00:39
@chapulina
broke up ign-msgs header
a9be772 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) January 5, 2022 01:05
@chapulina chapulina merged commit a4cc0f4 into ros2 Jan 5, 2022
@chapulina chapulina deleted the ros2_test_improvements branch January 5, 2022 01:27
Core development automation moved this from In review to Done Jan 5, 2022
mjcarroll added a commit that referenced this pull request Feb 7, 2022
@mjcarroll @chapulina
Improve modularity of ign/ros publisher tests (#194)
cf6a2d6 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
mjcarroll added a commit that referenced this pull request Feb 7, 2022
@mjcarroll @chapulina
[galactic] backport test memory usage improvements (#215)
3313124 
* Improve modularity of ign/ros publisher tests (#194)
* Break apart ros_subscriber test translation unit (#212)
* Fix deprecated parameter declaration

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@mjcarroll mjcarroll

Labels
ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjcarroll @chapulina