Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically link each translation unit #193

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Conversation

mjcarroll
Copy link
Collaborator

Builds on #192 to make each group of messages a separate static library that is linked together into the bridge library.

@osrf-triage osrf-triage added this to Inbox in Core development Dec 22, 2021
@mjcarroll mjcarroll self-assigned this Dec 22, 2021
@mjcarroll mjcarroll added the ROS 2 ROS 2 label Dec 22, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Dec 22, 2021
Base automatically changed from ros2_tu_improvements to ros2 December 23, 2021 19:59
@chapulina
Copy link
Contributor

#192 is in, and now there are lots of conflicts here. I think the CMakeLists is the main one that needs close attention

@mjcarroll
Copy link
Collaborator Author

Strange, probably just needs a rebase, I'll take care of it

@chapulina
Copy link
Contributor

Strange, probably just needs a rebase

I think it's because the commit ID changed when the other PR was squashed :/

I'll take care of it

Thanks!

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chapulina chapulina merged commit 91b84ef into ros2 Dec 23, 2021
Core development automation moved this from In review to Done Dec 23, 2021
@chapulina chapulina deleted the ros2_tu_improvements_static branch December 23, 2021 22:25
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROS 2 ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants