Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all ignition references on ROS 2 branch #302

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Conversation

mjcarroll
Copy link
Collaborator

🎉 New feature

Summary

This completes the migration:

  • Remove ros_ign shims
  • Remove ignition headers
  • Remove ignition.msgs references

Note: Once merged, the ros2 branch will only support collections that have the full renaming applied (at this time garden only)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit 5bf7cb1 into ros2 Sep 26, 2022
@mjcarroll mjcarroll deleted the mjcarroll/ros2_garden branch September 26, 2022 18:06
@moriarty moriarty mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants