Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nav_msgs/OccupancyGrid #137

Merged
merged 6 commits into from Mar 22, 2021
Merged

Add support for nav_msgs/OccupancyGrid #137

merged 6 commits into from Mar 22, 2021

Conversation

mjcarroll
Copy link
Collaborator

@mjcarroll mjcarroll commented Feb 26, 2021 •
edited by chapulina

馃帀 New feature

Depends on gazebosim/gz-msgs#138

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge

@osrf-triage osrf-triage added this to Inbox in Core development Feb 26, 2021
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Feb 27, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Mar 1, 2021
Base automatically changed from add_marker to melodic March 8, 2021 15:34
acschang
acschang reviewed Mar 9, 2021
View reviewed changes
Copy link

@acschang acschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a couple of odd error messages regarding MarkerArray messages when launching despite that functionality working. The OccupancyGrid message bridge is not yet functional on this branch (you're probably aware of this):
[ERROR] [1615316299.701832622]: Failed to create a bridge for topic [/model/<robo_name>/grid] with ROS type [nav_msgs/OccupancyGrid] and Ignition Transport type [ignition.msgs.OccupancyGrid].

ros_ign_bridge/src/factories.cpp Outdated Show resolved Hide resolved
ros_ign_bridge/src/factories.cpp Outdated Show resolved Hide resolved
@chapulina chapulina added the ROS 1 ROS 1 label Mar 10, 2021
@acschang acschang mentioned this pull request Mar 12, 2021
Merged
@mjcarroll
Add support for nav_msgs/OccupancyGrid
3505f70 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Fix things that were broken during rebase
a9a9449 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Copy link
Collaborator Author

Sorry, the message bridge got busted off a bad rebase as I was originally working on the noetic branch. This should be good now.

chapulina
chapulina suggested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The melodic branch is supposed to build from source against Citadel, so we'll need to backport and release gazebosim/gz-msgs#138 first.

@mjcarroll
Copy link
Collaborator Author

The melodic branch is supposed to build from source against Citadel, so we'll need to backport and release gazebosim/gz-msgs#138 first.

Backport PR: gazebosim/gz-msgs#143

@mjcarroll mjcarroll mentioned this pull request Mar 17, 2021
Merged
5 tasks
@mjcarroll
Fix removed line
9a4efcf 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
iche033
iche033 reviewed Mar 19, 2021
View reviewed changes
ros_ign_bridge/test/test_utils.h Outdated Show resolved Hide resolved
ros_ign_bridge/test/test_utils.h Show resolved Hide resolved
@mjcarroll
Be more explicit about signedness
3d431c1 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Merge branch 'melodic' into add_map
05efbfe
@chapulina chapulina merged commit 117e2b2 into melodic Mar 22, 2021
Core development automation moved this from In review to Done Mar 22, 2021
@chapulina chapulina deleted the add_map branch March 22, 2021 15:19
@chapulina chapulina moved this from Done to Highlights in Core development Mar 29, 2021
@sloretz sloretz mentioned this pull request Aug 11, 2021
Open
@j-rivero j-rivero removed this from Highlights in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 left review comments

@acschang acschang acschang left review comments

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
needs upstream release Blocked by a release of an upstream library ROS 1 ROS 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjcarroll @iche033 @chapulina @acschang