-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera: fix default trigger topic #1006
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Otherwise it has a value of __default__/trigger Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #1006 +/- ##
=======================================
Coverage 65.38% 65.38%
=======================================
Files 2 2
Lines 26 26
=======================================
Hits 17 17
Misses 9 9 Continue to review full report at Codecov.
|
Then we don't need to check HasElement before getting its value. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #1006 +/- ##
=======================================
Coverage 65.38% 65.38%
=======================================
Files 2 2
Lines 26 26
=======================================
Hits 17 17
Misses 9 9 Continue to review full report at Codecov.
|
🦟 Bug fix
Fixes default trigger topic when unset
Summary
In gazebosim/gz-sensors#215 (comment) I noticed that if the trigger topic name is not explicitly set in SDFormat that ign-sensors uses
__default__/trigger
as the default trigger topic name. I believe this is due to the way the DOM object is loaded, so I have adjusted it in 361fa6a to only read the value of thetrigger_topic
element if that element exists. Thus it will return an empty string""
if no trigger topic is specified, leaving the default behavior up to the downstream library (ign-sensors in the case I noticed).Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.